This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Refactor buttons on about:preferences#payments and bookmark dialog #5705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
added
refactoring
feature/rewards
design
luixxiul
changed the title
luixxiul
changed the title
|
With 23207ed the bookmark dialogs becomes like these:
The difference of font-size between "Remove" and "Done" which exists on master was fixed on both of the dialogs Edit:
Issue #6004 The remaining task is: #6400 |
luixxiul
changed the title
|
@luixxiul This is awesome. Thanks for the great cleanup work here. |
This was referenced Nov 21, 2016
added 2 commits
November 22, 2016 10:06
Fixes #4786 - Moved paddings and width in "whiteButton" to "wideButton" - Added "wideButton" to the advanced settings button on about:preferences#payments - Added font-size to the button - Added display:flex to footer of advanced settings - Added white-space:nowrap to "buttonCommon" (buttons will not be wrapped by default) Auditors: @jkup Test Plan: 1. Open about:preferences#payments 2. Make sure the font size of the two buttons "Add funds" and "Advanced Settings..." is equal 3. Click "Advanced Settings..." 4. Make sure the buttons on the footer are aligned center 5. Make sure each button is not wrapped
- Removed redundant classes from bookmarkButtons to fix the size difference between "Remove" and "Done" buttons, which was introduced with the commit 85e428a - Introduced new classes "removeButton" and "doneButton" inside bookmarkButtons to make the width of the row same as the other rows - Introduced a new class "copyButton" to keep the font-size of the recovery key copy buttons to 14px - Indroduced a flexbox to copyKeyContainer to keep the buttons aligned Auditors: @bradleyrichter Test Plan: 1. Click the bookmark button on the URL bar 2. Make sure height of "Remove" and "Done" buttons is equal 3. Make sure "Remove" button is longer than "Done" button 4. Make sure color of "Remove" label is no longer white on hover 5. Make sure width of the row of the buttons is equal to the other rows 6. Open about:bookmarks and edit a bookmark 7. Make sure height and width of "Remove" and "Done" are equal 8. Open about:preferences#payments, click Advanced Settings and Backup your wallet 9. Make sure keys and buttons are aligned 10. Make sure font-size of the labels "Copy" is 14px
|
Rebased and ready for a review again @bradleyrichter |
|
This looks great! 😄 @jkup do these changes affect what you're working on? I know you're in the process of converting buttons over to an Aphrodite component |
|
@bsclifton nope this is all good! Been keeping an eye on these changes! |
|
@luixxiul killer job with all your recent PRs; the style updates definitely help Brave feel more polished. Keep up the great work! 😄 |
|
OK, I think it's good to merge.. |
This was referenced Dec 12, 2016
This was referenced Dec 20, 2016
This was referenced Dec 21, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fixes #4786
Fixed #5894
Auditors: @jkup @bradleyrichter
Test Plan: explained in messages of the commits 75a754a 23207ed