This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Aligned the bookmark icon on the navbar #5739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
commented
Nov 19, 2016
| width: 15px; | ||
| height: 15px; | ||
| position: relative; | ||
| left: 5px; |
There was a problem hiding this comment.
This 5px is a magic number. At first I tried display: flex, justify-content: center, but it did not work well with box-sizing: border-box on macOS, while it did on Ubuntu.
|
This is not working right on macOS:
|
|
or in master:
|
|
Conflicted. I will rebase. |
Fixes #5632 Auditors: @bradleyrichter Test Plan: make sure the bookmark icon is properly aligned on each platforms
|
Updated. Please review, thanks. |
|
++ |
This was referenced Dec 1, 2016
This was referenced Dec 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).This PR addresses the issue which was caused by introducing SVG toolbar icons and placing them with pixels, by removing margins around the bookmark icon and setting
background-size.Fixes #5632
Auditors: @bradleyrichter
Test Plan: make sure the bookmark icon is properly aligned on each platforms
Image 1: on Ubuntu
Image 2: on macOS
Related: #5173 #4852