Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Aligned the bookmark icon on the navbar #5739

Merged
merged 1 commit into from
Nov 29, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion less/forms.less
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@
left: 37px;

&.withHomeButton {
left: 67px;
left: 61px;
}
}

Expand Down
17 changes: 10 additions & 7 deletions less/navigationBar.less
Original file line number Diff line number Diff line change
Expand Up @@ -564,8 +564,8 @@
.navigationButton {
background-color: @buttonColor;
display: inline-block;
width: 12px;
height: 14px;
width: 100%;
height: 100%;
margin: 0 7px 0 0;
}

Expand Down Expand Up @@ -645,13 +645,17 @@
.bookmarkButton {
background: url('../img/toolbar/bookmark_btn.svg') center no-repeat;
-webkit-mask-repeat: no-repeat;
background-size: 14px 14px;
margin: 0;
height: 0;
width: 14px;
height: 14px;
margin-bottom: 2px;
margin-left: 6px;
position: relative;
left: 5px;
Copy link
Contributor Author

@luixxiul luixxiul Nov 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This 5px is a magic number. At first I tried display: flex, justify-content: center, but it did not work well with box-sizing: border-box on macOS, while it did on Ubuntu.


&.removeBookmarkButton {
background: url('../img/toolbar/bookmark_marked.svg') center no-repeat;
background-size: 14px 14px;
}
}
}
Expand Down Expand Up @@ -766,10 +770,9 @@
border-top-right-radius: 0;
border-bottom-right-radius: 0;
box-sizing: border-box;
display: block;
height: 25px;
line-height: 25px;
margin-right: -2px;
display: inline-block;
width: 25px;
}
}

Expand Down