Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Avoid race condition on publisherToggle #7498

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Avoid race condition on publisherToggle #7498

merged 1 commit into from
Mar 9, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Mar 4, 2017 •
edited by bsclifton
Loading

Auditors: @bsclifton

Fix #7497

Test Plan:

  1. Have a clean session file
  2. Go to preferences->payments
  3. Enable payments
  4. Open browser console
  5. Go to an url from there
  6. No errors should be thrown
  7. Url should load instantly

@cezaraugusto cezaraugusto added this to the 0.13.6 milestone Mar 4, 2017
@cezaraugusto cezaraugusto self-assigned this Mar 4, 2017
@cezaraugusto cezaraugusto requested a review from bsclifton March 4, 2017 19:00
@cezaraugusto cezaraugusto mentioned this pull request Mar 4, 2017
Closed
bsclifton
bsclifton approved these changes Mar 9, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit f6e9063 into brave:master Mar 9, 2017
@bsclifton bsclifton mentioned this pull request Mar 10, 2017
Closed
@cezaraugusto cezaraugusto deleted the hotfix/7497 branch July 25, 2017 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
settings
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cezaraugusto @bsclifton