Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Attributes::remove with IndexMap::swap_remove #53

Merged
merged 1 commit into from
May 15, 2024
Merged

Implement Attributes::remove with IndexMap::swap_remove #53

merged 1 commit into from
May 15, 2024

Commits on May 14, 2024

  1. Implement Attributes::remove with IndexMap::swap_remove 

    Use the explicit call instead of the deprecated `remove` method.
This has the same behaviour as the previous call, so there is
no change to the public API.

The intent it so make explicit that the call swaps the last
element in the map into the place of the removed element,
which is O(1), vs. `shift_remove` which maintains ordering
but is O(n).

Addresses a deprecation warning with indexmap v2.2.6.
    @rillian
    rillian committed May 14, 2024
    Configuration menu
    Copy the full SHA
    dd07257 View commit details
    Browse the repository at this point in the history