Implement Attributes::remove with IndexMap::swap_remove #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the explicit call instead of the deprecated `remove` method. This has the same behaviour as the previous call, so there is no change to the public API. The intent it so make explicit that the call swaps the last element in the map into the place of the removed element, which is O(1), vs. `shift_remove` which maintains ordering but is O(n). Addresses a deprecation warning with indexmap v2.2.6.
antonok-edm
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the explicit call instead of the deprecated
removemethod. This has the same behaviour as the previous call, so there is no change to the public API.The intent it so make explicit that the call swaps the last element in the map into the place of the removed element, which is O(1), vs.
shift_removewhich maintains ordering but is O(n).Addresses a deprecation warning with indexmap v2.2.6.