Port recent fixes to the speedreader branch #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rillian
commented
May 15, 2024
rillian
commented
- Migrate to indexmap v2.2.6 (resolves Migrate speedreader to indexmap v2 #45)
- Fix doctests (backport Fix doctests #55)
- Address clippy warnings (backport Implement Attributes::remove with IndexMap::swap_remove #53, impl Display for NodeRef #54)
- Align github actions scripts to reduce diff noise
- Bump version for pre-release testing
Use the explicit call instead of the deprecated `remove` method. This has the same behaviour as the previous call, so there is no change to the public API. The intent it so make explicit that the call swaps the last element in the map into the place of the removed element, which is O(1), vs. `shift_remove` which maintains ordering but is O(n). Addresses a deprecation warning with indexmap v2.2.6.
Replace the `std::string::ToString` impl with `std::fmt::Display`. `ToString` is implemented in the std library for all `Display` types, so documentation recommends implementing the more general trait instead. The new trait method is fallible, returning `fmt::Error` instead of `unwrap()` on serialization failure, but the blanket `to_string` impl converts this to a panic so the only behavior change is a less-localized error message. Serialization shouldn't fail so this isn't a major concern. Addresses a clippy lint.
Copy recent changes to the github actions continuous integration scripts from the main branch.
This is a major version bump, but our use isn't affected by api changes. The `std` feature is enabled by default, so there's not need to specify it directly.
Doctests have always been disabled in this repo. Add sufficient annotations so that they pass and re-enable them. As far as I can tell, the first `cell_extras` example is not supposed to compile, demonstrating the soundness of the extension trait. Perhaps this is why the tests were disabled. It looks like the `compile_fail` annotation was stablized in 2017 with rust 1.22.0.
Prepare to release recent changes to the speedreader branch.
antonok-edm
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.