Skip to content

Commit

Permalink
Expand notes.
Browse files Browse the repository at this point in the history
  • Loading branch information
bredelings committed Jan 15, 2025
1 parent 7dd19c7 commit 139b9fd
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions src/models/rules.cc
Original file line number Diff line number Diff line change
Expand Up @@ -216,13 +216,19 @@ ptree convert_rule(const Rules& R, const string& name, Rule rule)
tc->mono_local_env() = tc->mono_local_env().insert({arg_name,{arg_name,type}});
}


// OK, now we need to typecheck the call expression.

// I guess this is a declaration? So it makes sense to run the solver.
// Do we want to import all the referenced modules and fill the poly_env before we start type checking?

// I guess this rule is a declaration? So it makes sense to run the solver.
// And then we decide which unsolved wanteds to quantify.
// Any remaining wanteds are errors.

// Question: how/when would we ensure that things like Num [String] cause an error?
// How do we efficiently look up the types of the haskell functions?
// We contain maintain a Program and add any modules that are referenced... but that would require changing the interface.

// Do we want to import all the referenced modules and fill the poly_env before we start type checking?
// How do we ensure that instances are in scope?

return rule;
}
Expand Down

0 comments on commit 139b9fd

Please sign in to comment.