Onchain payment flow: add more logging #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangeross
approved these changes
Nov 7, 2024
roeierez
added a commit
that referenced
this pull request
Nov 17, 2024
* commit '1cbe6d7a8045df6474eba131a298df30e066c84f': fix typo fix clilppy wipe storage cache in case of data corrupted issue Log errors on starting an SDK instance (#565) Notify success when waiting for claim confirmation (#562) Validate the pay_onchain address (#561) Liquid/Lightning drain (#553) Monitor server lockup tx in thread to verify/claim (#557) Update README.md Fix chronological order of `list_payments` (#552) Onchain payment flow: add more logging (#551) Store claim_address for incoming chain swap when claiming (#548)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more logging to the start of the onchain payment flow, so that we can better determine which path was taken when troubleshooting: that of drain, or pay user-specified amount.