Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chronological order of list_payments #552

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

dangeross
Copy link
Collaborator

This PR:

  • Fixes chronological payment ordering, first ordering by swap creation timestamp then tx timestamp
  • Fixes use of tx timestamp in payment

Fixes #540

@dangeross dangeross merged commit 92e7384 into main Nov 7, 2024
8 checks passed
@dangeross dangeross deleted the savage-payments-ordering branch November 7, 2024 17:07
roeierez added a commit that referenced this pull request Nov 17, 2024
* commit '1cbe6d7a8045df6474eba131a298df30e066c84f':
  fix typo
  fix clilppy
  wipe storage cache in case of data corrupted issue
  Log errors on starting an SDK instance (#565)
  Notify success when waiting for claim confirmation (#562)
  Validate the pay_onchain address (#561)
  Liquid/Lightning drain (#553)
  Monitor server lockup tx in thread to verify/claim (#557)
  Update README.md
  Fix chronological order of `list_payments` (#552)
  Onchain payment flow: add more logging (#551)
  Store claim_address for incoming chain swap when claiming (#548)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list_payments: Pending payments break reverse chronological order
3 participants