Add cppcheck target; Fixup cppcheck errors [BUG-116];

brezerk · Sep 28, 2017 · 961a07c · 961a07c
1 parent c0fdb67
commit 961a07c
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -365,3 +365,18 @@ add_subdirectory(l10n)
 IF (${CMAKE_SYSTEM_NAME} MATCHES FreeBSD)
     add_subdirectory(freebsd)
 ENDIF (${CMAKE_SYSTEM_NAME} MATCHES FreeBSD)
+
+add_custom_target(cppcheck COMMAND cppcheck
+	--quiet
+	--force
+	--inconclusive
+	--error-exitcode=254
+	-I ${CMAKE_SOURCE_DIR}
+	-I ${CMAKE_SOURCE_DIR}/src/q4wine-gui
+	-I ${CMAKE_SOURCE_DIR}/src/q4wine-cli
+	-I ${CMAKE_SOURCE_DIR}/src/q4wine-helper
+	-I ${CMAKE_SOURCE_DIR}/src/q4wine-lib
+	-i qrc_q4wine.cpp
+	-i ${CMAKE_SOURCE_DIR}/build/
+	${CMAKE_SOURCE_DIR}
+	)
diff --git a/src/core/xmlparser.cpp b/src/core/xmlparser.cpp
@@ -18,9 +18,8 @@
 
 #include "xmlparser.h"
 
-XmlParser::XmlParser(void)
+XmlParser::XmlParser(void): appdb_appinfo(WineAppDBInfo())
 {
-    appdb_appinfo=WineAppDBInfo();
     page_current=0;
     page_count=0;
     return;

diff --git a/src/darwin/ps.c b/src/darwin/ps.c
@@ -152,7 +152,7 @@ static char* getenvinfo(KINFO *k)
 {
     int mib[3], argmax, nargs, c = 0;
     size_t size;
-    char	 *procargs, *sp, *np, *cp;
+    char	 *procargs, *sp = NULL, *np, *cp;
 
     /* Get the maximum process arguments size. */
     mib[0] = CTL_KERN;