Remove -std=c++11 in CXXFLAGS #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default mode on a system should be fine in most cases. If a user needs to declare a special `-std` they can easily do it themselves by passing `--with-cxxflags=-std=c++11`.
Facebook203
approved these changes
Jul 7, 2024
Facebook203
approved these changes
Jul 7, 2024
|
@tenderlove This actually broke compiling the extension for macOS: #177. #179 seems to solve the issue for me. Probably worth adding macOS to CI. |
|
@stanhu ugh. Thanks for sending the PR. I'll add macOS to CI too. Thank you! |
|
@stanhu @tenderlove Sorry for breaking it for macOS 🙈 But running |
|
@rnestler don't worry about it, we didn't have CI before (but we do now). Also yes, it should work fine if you pass the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default mode on a system should be fine in most cases. If a user needs to declare a special
-stdthey can easily do it themselves by passing--with-cxxflags=-std=c++11.Fixes #173