Auto-detect C++ extensions needed to build #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 9, 2024
stanhu
commented
Jul 9, 2024
clang requires manually enabling C++ extensions via `-std=c++<version>`, and ICU 75.1 needs C++17. Auto-detect the flags that are needed to build. Relates to brianmario#172 Closes brianmario#177
C++ compilation failed without these explicit casts.
stanhu
force-pushed
the
sh-auto-detect-cxx-flags
branch
from
1b5b275
to
7f026b4
Compare
Now that a C++ compiler is used to support later versions of ICU, we need to surround all C code with `extern "C"` to avoid name mangling that would cause issues with symbol resolution on macOS.
stanhu
force-pushed
the
sh-auto-detect-cxx-flags
branch
from
405d3c6
to
01df9a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain versions of clang (e.g. 15.0 on macOS) require manually enabling C++ extensions via
-std=c++<version>, and ICU 75.1 needs C++17. Auto-detect the flags that are needed to build.The default C++ version depends on the version of clang:
clang 15.0.0 (macOS Sonoma)
On clang 18.1.8 (shipped with
archlinux/archlinux:base):Relates to #172
Closes #177