-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WX-1385 Remove SAS tokens from TES input log printouts #7358
Conversation
import akka.http.scaladsl.model.Uri | ||
|
||
// Remove query that may contain SAS token | ||
val cleanUrl = url map { Uri(_).copy(rawQueryString = None).toString() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about only stripping out query params when we can tell the URL contains a SAS token?
Also, can we replace with ?REDACTED
or similar so we can tell something was removed? I can imagine users or our future selves not realizing this is happening and thinking Cromwell is incorrectly stripping the query params before passing the URL to TES.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to enhance and adopt an existing library function for this!
scalafmt |
This reverts commit 06e5932.
DBMS issues seem to be a systemic issue with a vendor fix in progress here: |
No description provided.