Add a cloudbuild configuration for building the docker image and propagating the new tag to a kubernetes manifest #92
Conversation
|
We can ignore the cloudbuild failure here -- that was due to https://github.com/broadinstitute/gnomad-terraform/pull/141 not being merged yet (and the trigger was pointed at this branch instead of main) |
deployment/README.md
Outdated
| @@ -136,6 +136,12 @@ If you would like to extend your deployment with things like an Ingress, additio | |||
|
|
|||
| ### Production Deployment | |||
|
|
|||
| ## Building the Docker image | |||
|
|
|||
| For production, docker images are automatically built after a push to the main branch. Once the build succeeds, retrieve the image tag from the build in Cloud Build, and update update the deployment spec in the [gnomad-deployments](https://github.com/broadinstitute/gnoma-deployments) repository. | |||
There was a problem hiding this comment.
Very minor -- I think there's a typo here, should this link to "https://github.com/broadinstitute/gnomad-deployments"?
The current link is missing the "d" - "...gnoma-deployments"
There was a problem hiding this comment.
yup, thanks, will fix
cloudbuild.yaml
Outdated
|
|
||
| - name: "gcr.io/cloud-builders/docker" | ||
| - name: 'gcr.io/kaniko-project/executor:latest' |
There was a problem hiding this comment.
Personal question out of curiosity -- what are the benefits and downsides of using latest here, as opposed to pinning to a specific version.
I ran into issues a while ago with GeniE once with Kaniko caching incorrectly that were seemingly quite old and would have been fixed if we were using latest, but on the other hand that same issue seemed to have been introduced as a regression, so a process that worked fine previously using latest could start spontaneously failing.
I have no issue with using latest, this comment is really just me being curious as to your thoughts on this front.
There was a problem hiding this comment.
Yeah, the pros and cons are pretty much what you mentioned there. For build-time environment dependencies, I'm sometimes OK with the latest tag, whereas I probably wouldn't be happy with that for a production deployment where you need to know exactly what versions of things you're running.
In this case, i think it's a good idea to have used the latest tag during development, but now that we have a version that we know works, we can pin to that (this will also help keep a record of which kaniko built which exome results image).
|
Approved with one minor typo and one question -- also with caveat that the Edit: oops saw your comment about being able to ignore the failures -- my bad on not reading that. Ignore the above mention of that. |
No description provided.