Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gauss-Legendre integration error #3317

Closed
davidbenjamin opened this issue Jul 21, 2017 · 5 comments
Closed

Gauss-Legendre integration error #3317

davidbenjamin opened this issue Jul 21, 2017 · 5 comments
Labels
Milestone

Comments

@davidbenjamin
Copy link
Contributor

We use Gauss-Legendre integration in the strand bias model. The number of subdivisions increases with the read count and for very deep coverage this can cause a stack overflow because, unfortunately, Apache Commons has a very questionable recursive implementation.

The short-term fix is to cap the number of subdivisions. The long-term fix is to write some sort of simple adaptive 1D and 2D quadrature method. This ticket is for the short-term fix.

@davidbenjamin davidbenjamin added this to the Popularize Mutect 2 at the Broad milestone Jul 21, 2017
@mbabadi
Copy link
Contributor

mbabadi commented Jul 21, 2017

See my comment on issue #3318

@vdauwera
Copy link
Contributor

Got another user reporting this problem -- this seems to be especially relevant for amplicon datasets where deep coverage is widespread.

@davidbenjamin
Copy link
Contributor Author

@vdauwera This is a big deal. I'll put in a quick fix tomorrow evening.

@vdauwera
Copy link
Contributor

Awesome thank you @davidbenjamin

@davidbenjamin
Copy link
Contributor Author

Closed by #3335.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants