Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping quality threshold in GetPileupSummaries needs to be modifiable #4011

Closed
eitanbanks opened this issue Dec 28, 2017 · 4 comments
Closed
Assignees

Comments

@eitanbanks
Copy link
Contributor

The MAPPING_QUALITY_THRESHOLD for GetPileupSummaries is hard coded at 50, but that's not documented anywhere -- and really is only good for BWA aligned reads. There are other mappers that are more spread in their mapping qualities and we lose so many reads.

Instead, please change this tool so that MAPPING_QUALITY_THRESHOLD is a command-line argument (and it's fine to have it set to 50 by default).

Thanks!

@eitanbanks
Copy link
Contributor Author

@davidbenjamin are you the right person for this?

@samuelklee
Copy link
Contributor

@davidbenjamin Note that this is not exposed in CollectAllelicCounts either and is set to 30 by default. Our default set of read filters is also less stringent. However, we do expose a threshold on minimum base quality. Just a few more things to consider when we unify the two tools!

@davidbenjamin
Copy link
Contributor

@eitanbanks Yes, I will fix this.

@davidbenjamin davidbenjamin self-assigned this Jan 5, 2018
@davidbenjamin
Copy link
Contributor

@eitanbanks Fixed in #4466.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants