fixup assert(true)

broadinstitute · Sep 20, 2022 · 0197596 · 0197596
1 parent aaa0366
commit 0197596
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 22 deletions.
diff --git a/src/test/java/picard/illumina/CollectIlluminaBasecallingMetricsTest.java b/src/test/java/picard/illumina/CollectIlluminaBasecallingMetricsTest.java
@@ -20,9 +20,7 @@ public class CollectIlluminaBasecallingMetricsTest {
 
     @BeforeTest
     private void setUp() throws Exception {
-        rootTestDir = Files.createTempDirectory("cibm." + ".tmp").toFile();
-        Assert.assertTrue(true);
-        Assert.assertTrue(true);
+        rootTestDir = Files.createTempDirectory("cibm.tmp").toFile();
         for (final File source : TEST_DATA_DIR.listFiles()) {
             if (source.isDirectory() && !source.isHidden()) {
                 IOUtil.copyDirectoryTree(source, new File(rootTestDir.getPath(),source.getName()));

diff --git a/src/test/java/picard/illumina/ExtractIlluminaBarcodesTest.java b/src/test/java/picard/illumina/ExtractIlluminaBarcodesTest.java
@@ -80,29 +80,19 @@ public String getCommandLineProgramName() {
 
     @BeforeTest
     private void setUp() throws Exception {
-        basecallsDir = Files.createTempDirectory("eib." + ".tmp").toFile();
-        Assert.assertTrue(true);
-        Assert.assertTrue(true);
+        basecallsDir = Files.createTempDirectory("eib.tmp").toFile();
         IOUtil.copyDirectoryTree(SINGLE_DATA_DIR, basecallsDir);
 
-        dual = Files.createTempDirectory("eib_dual" + ".tmp").toFile();
-        Assert.assertTrue(true);
-        Assert.assertTrue(true);
+        dual = Files.createTempDirectory("eib_dual.tmp").toFile();
         IOUtil.copyDirectoryTree(DUAL_DATA_DIR, dual);
 
-        qual = Files.createTempDirectory("eib_qual" + ".tmp").toFile();
-        Assert.assertTrue(true);
-        Assert.assertTrue(true);
+        qual = Files.createTempDirectory("eib_qual.tmp").toFile();
         IOUtil.copyDirectoryTree(DUAL_DATA_DIR, qual);
 
-        noSymlink = Files.createTempDirectory("eib_nosymlink" + ".tmp").toFile();
-        Assert.assertTrue(true);
-        Assert.assertTrue(true);
+        noSymlink = Files.createTempDirectory("eib_nosymlink.tmp").toFile();
         IOUtil.copyDirectoryTree(HISEQX_DATA_DIR, noSymlink);
 
-        cbcl = Files.createTempDirectory("eib_cbcl" + ".tmp").toFile();
-        Assert.assertTrue(true);
-        Assert.assertTrue(true);
+        cbcl = Files.createTempDirectory("eib_cbcl.tmp").toFile();
         IOUtil.copyDirectoryTree(CBCL_DATA_DIR, cbcl);
         // For the cbcl test, we are deleting the '*barcode.txt.gz' files that exist in the test Basecalls directory
         // This is to prevent the error conditon that was briefly introduced which expected to find such files in that

diff --git a/src/test/java/picard/illumina/IlluminaBasecallsToFastqTest.java b/src/test/java/picard/illumina/IlluminaBasecallsToFastqTest.java
@@ -186,7 +186,7 @@ public void testQualityAndAdapterTrimming() throws Exception {
 
     @Test
     public void testMultiplexWithIlluminaReadNameHeaders() throws Exception {
-        final File outputDir = Files.createTempDirectory("testMultiplexRH." + ".dir").toFile();
+        final File outputDir = Files.createTempDirectory("testMultiplexRH.dir").toFile();
         try {
             outputDir.deleteOnExit();
 

diff --git a/src/test/java/picard/metrics/CollectRrbsMetricsTest.java b/src/test/java/picard/metrics/CollectRrbsMetricsTest.java
@@ -51,9 +51,7 @@ public class CollectRrbsMetricsTest extends CommandLineProgramTest {
 
     @BeforeTest
     private void setUp() throws Exception {
-        rootTestDir = Files.createTempDirectory("crmt." + ".tmp").toFile();
-        Assert.assertTrue(true);
-        Assert.assertTrue(true);
+        rootTestDir = Files.createTempDirectory("crmt.tmp").toFile();
     }
 
     @AfterTest