Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning and formating files in the ICEsat2_SI_tools folder #132

Merged
merged 26 commits into from
Mar 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
2aed3e7
cleaning and formating files form the ICEsat2_SI_tools folder
kmilo9999 Feb 26, 2024
45dca27
applying review comments
kmilo9999 Feb 26, 2024
d2dcd36
applying suggested changed in review
kmilo9999 Feb 28, 2024
9aef485
fix bug on beam_stats.py
kmilo9999 Feb 28, 2024
2f47162
fix: update xlabel, ylabel to set_xlabel, set_ylabel
cpaniaguam Feb 28, 2024
f595370
it seems spectral_estimates.py was not included in the last commit
kmilo9999 Feb 29, 2024
5be7f89
Merge branch 'clean-files-tools' of https://github.com/brown-ccv/ices…
kmilo9999 Feb 29, 2024
708e6a9
added astropy dependency
kmilo9999 Feb 29, 2024
0e5dc6d
removing calls to create_chunk_boundaries
kmilo9999 Feb 29, 2024
d3e5d55
Fixed create_chunk_boundaries implementaiton
kmilo9999 Feb 29, 2024
4beefa8
fixed imports and function argument types
kmilo9999 Feb 29, 2024
8c05ea4
refactor create_chunk_boundaries function
kmilo9999 Feb 29, 2024
e9ddc4e
added review suggestions
kmilo9999 Mar 1, 2024
082478f
fix: update xlabel, ylabel to set_xlabel, set_ylabel
cpaniaguam Feb 28, 2024
99c2eb7
cleaning and formatting more files in ICEsat2_SI_tools folder
kmilo9999 Mar 1, 2024
18c665d
applied suggested changes in review
kmilo9999 Mar 3, 2024
8988ae7
remove int cast
kmilo9999 Mar 3, 2024
0713cf8
merge with main
kmilo9999 Mar 5, 2024
cdcbd40
Adding some changes missed in the last commit
kmilo9999 Mar 5, 2024
7d5e579
more missed changes in previous commits
kmilo9999 Mar 5, 2024
b9d963c
fixed bug in spectral_estimates.py
kmilo9999 Mar 6, 2024
ca11ecd
Merge branch 'main' into clean-files-tools
kmilo9999 Mar 7, 2024
290c386
applied suggested changed in review
kmilo9999 Mar 7, 2024
197b576
Merge branch 'clean-files-tools' of https://github.com/brown-ccv/ices…
kmilo9999 Mar 7, 2024
c60d0d7
file spectral_estimates.py formatted
kmilo9999 Mar 7, 2024
356d9f2
added some code refactoring
kmilo9999 Mar 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ dependencies = [ # Optional
"h5py >=3.5.0, < 4.0.0",
"termcolor >=2.4.0, < 3.0.0",
"typer >=0.9.0, < 1.0.0",
"getmem >=1.0, <= 1.0.0",
"astropy >=5.2, <= 6.0.0"
Comment on lines +127 to +128
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these added? Just curious.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing conditional imports to the top of the files make the interpreter loom for those dependencies when running the scripts

]

# List additional groups of dependencies here (e.g. development
Expand Down
Loading