Cleaning and formating files in the ICEsat2_SI_tools folder #132
Conversation
kmilo9999
requested review from
cpaniaguam and
hollandjg
and removed request for
cpaniaguam
…at2-tracks into clean-files-tools
|
@cpaniaguam @hollandjg Check my replies on the opened conversations and do a last review. |
There was a problem hiding this comment.
Thanks for this! It looks like there are more changes here than just cleaning and formatting – some of the changes to functions look like they need more detailed tests before we can make them.
Is it possible to split this into a PR which does just cleanup, and another (or several) which make functional changes?
src/icesat2_tracks/analysis_db/A01b_ALT07_SHNH_variance_tester.py
Outdated
Show resolved
Hide resolved
|
@hollandjg I removed the latest changes in |
|
@cpaniaguam one last review on your side? |
| "getmem >=1.0, <= 1.0.0", | ||
| "astropy >=5.2, <= 6.0.0" |
There was a problem hiding this comment.
Why were these added? Just curious.
There was a problem hiding this comment.
Removing conditional imports to the top of the files make the interpreter loom for those dependencies when running the scripts
|
@cpaniaguam I added few changes requested in old conversations. Some of the doesnt seem to be reflected in their respective conversation. Please re-review and approve if you think is ready. |
| self.Lpoints = Lpoints | ||
| self.ov = int(Lpoints/2) if ov is None else ov #when not defined in create_chunk_boundaries then L/2 | ||
| self.Lpoints = Lpoints | ||
| self.ov = int(Lpoints / 2) if ov is None else ov |
No description provided.