-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning and formating files in the ICEsat2_SI_tools folder #132
Merged
Merged
Changes from 15 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
2aed3e7
cleaning and formating files form the ICEsat2_SI_tools folder
kmilo9999 45dca27
applying review comments
kmilo9999 d2dcd36
applying suggested changed in review
kmilo9999 9aef485
fix bug on beam_stats.py
kmilo9999 2f47162
fix: update xlabel, ylabel to set_xlabel, set_ylabel
cpaniaguam f595370
it seems spectral_estimates.py was not included in the last commit
kmilo9999 5be7f89
Merge branch 'clean-files-tools' of https://github.com/brown-ccv/ices…
kmilo9999 708e6a9
added astropy dependency
kmilo9999 0e5dc6d
removing calls to create_chunk_boundaries
kmilo9999 d3e5d55
Fixed create_chunk_boundaries implementaiton
kmilo9999 4beefa8
fixed imports and function argument types
kmilo9999 8c05ea4
refactor create_chunk_boundaries function
kmilo9999 e9ddc4e
added review suggestions
kmilo9999 082478f
fix: update xlabel, ylabel to set_xlabel, set_ylabel
cpaniaguam 99c2eb7
cleaning and formatting more files in ICEsat2_SI_tools folder
kmilo9999 18c665d
applied suggested changes in review
kmilo9999 8988ae7
remove int cast
kmilo9999 0713cf8
merge with main
kmilo9999 cdcbd40
Adding some changes missed in the last commit
kmilo9999 7d5e579
more missed changes in previous commits
kmilo9999 b9d963c
fixed bug in spectral_estimates.py
kmilo9999 ca11ecd
Merge branch 'main' into clean-files-tools
kmilo9999 290c386
applied suggested changed in review
kmilo9999 197b576
Merge branch 'clean-files-tools' of https://github.com/brown-ccv/ices…
kmilo9999 c60d0d7
file spectral_estimates.py formatted
kmilo9999 356d9f2
added some code refactoring
kmilo9999 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were these added? Just curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing conditional imports to the top of the files make the interpreter loom for those dependencies when running the scripts