Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make console window visually persistent if open #314

Closed
wants to merge 1 commit into from

Conversation

vinsworldcom
Copy link
Contributor

Fix #312

@vinsworldcom
Copy link
Contributor Author

vinsworldcom commented Nov 14, 2023

Still doesn't work. I think the ID of the menu command for "Show Console" (should be 1) is wrong. I see the menu IDs are calculated dynamically due to adding scripts to the menu. This may impact how Notepad++ sees the menu item IDs.

m_funcItems[position]._pFunc = m_runScriptFuncs[position - dynamicStartIndex];

@rdipardo
Copy link

Still doesn't work. I think the ID of the menu command for "Show Console" (should be 1) is wrong.

The issue is indeed both the module name and the dialog ID, as @xomx figured out à propos a larger issue with the Docking Manager: notepad-plus-plus/notepad-plus-plus#13084 (comment)

@xomx
Copy link
Contributor

xomx commented Nov 15, 2023

I have this on my TODO, but unfortunately no free time...
Needs to be fixed:

  • m_data->pszModuleName = _T("PythonScript.dll");
  • m_data->dlgID = 1;
  • PS plugin initialization way/sequence

The last item could be simple but I made a mental note to myself that it is also necessary to check if there is not a deeper reason for the current PS initialization way. As I am not conversant with the PS code, this needs testing & debugging from my side, so I have not pursued the fix further yet.

But now I got an idea how to solve this without changing the plugin initialization way. I will let you know, hopefully this afternoon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console not persistent visible during relaunch
3 participants