Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rankine Cycle Example #26

Merged
merged 5 commits into from
Apr 12, 2020
Merged

Fix Rankine Cycle Example #26

merged 5 commits into from
Apr 12, 2020

Commits on Apr 12, 2020

  1. Fixes dimensionality error in Rankine example 

    The Rankine cycle example had a dimensionality error due to the extra
units multiplication on the linspace. It seems like linspace includes
units now instead of dropping them.

Fixes #24
    @bryanwweber
    bryanwweber committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    ceaf370 View commit details
    Browse the repository at this point in the history

  2. Set up Matplotlib for use with Pint 

    Pint now includes a function to use Matplotlib correctly. This requires
Pint >=0.9. With this function, Matplotlib takes arrays with units
attached and plots them automatically. This also requires small changes
to the examples. np.arange does not support Quantities as arguments, so
switch to np.linspace which has that support. Create arrays for
accumulation of results, since lists don't seem to work properly with
when units are involved.
    @bryanwweber
    bryanwweber committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    d947490 View commit details
    Browse the repository at this point in the history

  3. Test example Jupyter Notebook files 

    Execute the example Notebooks in the docs folder as part of the tests.
Any warnings from Pint should hopefully become errors.
    @bryanwweber
    bryanwweber committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    0a30826 View commit details
    Browse the repository at this point in the history

  4. Build CoolProp so we can test on Python 3.8 

    CoolProp 6.3.0 from PyPI raises a TypeError due to some changes that
since the release of Python 3.8. The master branch of CoolProp has
the fixes, so build that and test ThermoState on Python 3.8.

Don't do this on Windows, since Windows should be covered by the
other Python versions, and I can't easily test compiling CoolProp
on Windows right now.
    @bryanwweber
    bryanwweber committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    3d105be View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG

    @bryanwweber
    bryanwweber committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    127de66 View commit details
    Browse the repository at this point in the history