Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request header to overcome server filters on Inventory(url=...) download attempts #109

Merged
merged 2 commits into from
Jan 24, 2020

Conversation

bskinn
Copy link
Owner

@bskinn bskinn commented Jan 24, 2020

Fixes #105.

Fixes #105; still need direct download tests of Flask, h5py
@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     11           
  Lines         585    587    +2     
=====================================
+ Hits          585    587    +2
Impacted Files Coverage Δ
src/sphobjinv/inventory.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b7c3aa...56c827b. Read the comment docs.

@bskinn bskinn merged commit 4fd0e40 into master Jan 24, 2020
@bskinn bskinn deleted the request-header branch January 24, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No inventory at provided URL
2 participants