Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respin glukasik's cgo zstd PR #559

Merged
merged 11 commits into from
Jul 17, 2022
Merged

respin glukasik's cgo zstd PR #559

merged 11 commits into from
Jul 17, 2022

Commits on Jul 9, 2022

  1. [zstd] add -zstd_implementation=cgo option 

    The cgo implementation may be more performant than the pure go
implementation, see buchgr#482 for benchmarks.
    @glukasiknuro @mostynb
    glukasiknuro authored and mostynb committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    19f7ebe View commit details
    Browse the repository at this point in the history

  2. [zstd] make zstdimpl.Get return an error instead of using log.Fatalf

    @mostynb
    mostynb committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    94a4346 View commit details
    Browse the repository at this point in the history

  3. [zstd] log zstd implementation mode (go/cgo) at startup

    @mostynb
    mostynb committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    0ca05c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. [zstd] add darwin-build.sh for quick iteration

    @mostynb
    mostynb committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    a004338 View commit details
    Browse the repository at this point in the history

  2. [zstd] add cgo system test

    @mostynb
    mostynb committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    f257568 View commit details
    Browse the repository at this point in the history

  3. Build linux release binaries on ubuntu 18.04 

    Since we use cgo now, and will potentially link against system libraries
we should use an older linux release to produce binaries that run on a
wider range of installs.
    @mostynb
    mostynb committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    245ee86 View commit details
    Browse the repository at this point in the history

  4. [zstd] remove IOReadCloser TODO note 

    github.com/klauspost/compress/zstd.Decoder has an IOReadCloser method
but Encoder doesn't, and zstdpool-syncpool keeps the same interface.
    @mostynb
    mostynb committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    9faa7de View commit details
    Browse the repository at this point in the history

  5. [zstd] fix infinite recursion in Close wrapper

    @mostynb
    mostynb committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    48f18d3 View commit details
    Browse the repository at this point in the history

  6. [ci] don't attempt to cross compile now that we use cgo

    @mostynb
    mostynb committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    1823529 View commit details
    Browse the repository at this point in the history

  7. go mod tidy

    @mostynb
    mostynb committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    67521a1 View commit details
    Browse the repository at this point in the history

  8. Build without static setting

    @mostynb
    mostynb committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    1067ffd View commit details
    Browse the repository at this point in the history