respin glukasik's cgo zstd PR #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostynb
force-pushed
the
glukasik_cgo_zstd_respin
branch
3 times, most recently
from
7909854
to
947f936
Compare
The cgo implementation may be more performant than the pure go implementation, see buchgr#482 for benchmarks.
mostynb
force-pushed
the
glukasik_cgo_zstd_respin
branch
from
947f936
to
46f5278
Compare
Since we use cgo now, and will potentially link against system libraries we should use an older linux release to produce binaries that run on a wider range of installs.
github.com/klauspost/compress/zstd.Decoder has an IOReadCloser method but Encoder doesn't, and zstdpool-syncpool keeps the same interface.
mostynb
force-pushed
the
glukasik_cgo_zstd_respin
branch
from
2bea90c
to
1067ffd
Compare
lizan
pushed a commit
to envoyproxy/ci-infra
that referenced
this pull request
Nov 3, 2022
This PR combines the following updates: - update of dependencies used in the AMIs built by Packer. - update of Node.js dependencies. Changes in this PR have **not** been tested on the AWS account used by Envoy's CI. As discussed offline, testing and deployment will be done during our meeting. I have verified that Packer builds the AMIs and the instances can start on a separate AWS account. Done here: - updated to the latest AZP agent as per https://github.com/microsoft/azure-pipelines-agent/releases. - Updated the source image for the AMIs to be Ubuntu Server 20.04 LTS. We cannot use 22.04 LTS yet due to hashicorp/packer#11733. - Switched to binary images for `bazel-remote` instead of building it form source, since the build process now also requires `build-essential` due to addition of `cgo` in buchgr/bazel-remote#559. - Updated Node.js dependencies. - documented the update process. Signed-off-by: Jakub Sobon <mumak@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #485.