Performing and documenting regular maintenance. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DO NOT MERGE, needs to be tested first. Done here: - updated to the latest AZP agent as per https://github.com/microsoft/azure-pipelines-agent/releases. - Updated the source image for the AMIs to be Ubuntu Server 20.04 LTS. We cannot use 22.04 LTS yet due to hashicorp/packer#11733. - Added `build-essential` to the AMIs built by Packer, as this is now required to build bazel-remote since the switch to cgo in buchgr/bazel-remote#559. Signed-off-by: Jakub Sobon <mumak@google.com> Signed-off-by: Jakub Sobon <jakub.sobon@elohim.sk>
Signed-off-by: Jakub Sobon <mumak@google.com> Signed-off-by: Jakub Sobon <jakub.sobon@elohim.sk>
Signed-off-by: Jakub Sobon <mumak@google.com> Signed-off-by: Jakub Sobon <jakub.sobon@elohim.sk>
Signed-off-by: Jakub Sobon <jakub.sobon@elohim.sk>
Signed-off-by: Jakub Sobon <jakub.sobon@elohim.sk>
Signed-off-by: Jakub Sobon <jakub.sobon@elohim.sk>
mum4k
changed the title
|
@lizan this is now ready for review. Please take a close look at the changes related to |
Signed-off-by: Jakub Sobon <jakub.sobon@elohim.sk>
|
@lizan I have addressed the offline feedback. We are now downloading and running the binaries of |
lizan
previously approved these changes
Oct 28, 2022
This is required since https://github.com/buchgr/bazel-remote/pull/492/files. Signed-off-by: Jakub Sobon <jakub.sobon@elohim.sk>
Signed-off-by: Jakub Sobon <jakub.sobon@elohim.sk>
Signed-off-by: Jakub Sobon <jakub.sobon@elohim.sk>
|
@lizan please take another look. I have added the missing This was started via systemctl using the content of the terraform's script. |
lizan
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines the following updates:
Changes in this PR have not been tested on the AWS account used by Envoy's CI. As discussed offline, testing and deployment will be done during our meeting. I have verified that Packer builds the AMIs and the instances can start on a separate AWS account.
Done here:
bazel-remoteinstead of building it form source, since the build process now also requiresbuild-essentialdue to addition ofcgoin respin glukasik's cgo zstd PR buchgr/bazel-remote#559.Signed-off-by: Jakub Sobon mumak@google.com