Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync cmd: Rework view/ui layer to show actions that are performed #105

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

andygrunwald
Copy link
Collaborator

@andygrunwald andygrunwald commented Sep 13, 2024

Context

This PR is a bit bigger (code line-wise).
It is reworking the UI to

  • make it a bit simpler to understand (e.g., via fewer message types)
  • list the operations in the UI

Caveats

sendMetrics

Right now, the sendMetrics command is shown with a spinner. When completed, it disappears and is not shown in the list of performed operations.
This part needs rework anyway to remove it from the logic where we are running a browser.
This will be done in a future pull request.

TODOs

A few things are still open - Those may be done in future pull requests (to avoid this is getting bigger)

Copy link
Contributor

@brgmn brgmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dope! ;) Much better user experience! Thanks!

@brgmn brgmn merged commit c888e37 into main Sep 14, 2024
2 checks passed
@brgmn brgmn deleted the show-action-items-in-sync-command branch September 14, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants