Skip to content

Commit

Permalink
chore: add source id to register events request (#915)
Browse files Browse the repository at this point in the history
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
  • Loading branch information
cre8ivejp authored Apr 15, 2024
1 parent f87a0c9 commit d09e2dd
Show file tree
Hide file tree
Showing 6 changed files with 47 additions and 26 deletions.
2 changes: 1 addition & 1 deletion manifests/bucketeer/charts/api-gateway/values.yaml

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions pkg/gateway/api/api_grpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -864,6 +864,7 @@ func (s *grpcGatewayService) RegisterEvents(
log.FieldsFromImcomingContext(ctx).AddFields(
zap.Error(err),
zap.Any("events", req.Events),
zap.Any("sourceId", req.SourceId),
zap.String("sdkVersion", req.SdkVersion),
)...,
)
Expand All @@ -873,6 +874,7 @@ func (s *grpcGatewayService) RegisterEvents(
s.logger.Error("Failed to validate RegisterEvents request. Missing events.",
log.FieldsFromImcomingContext(ctx).AddFields(
zap.Error(err),
zap.Any("sourceId", req.SourceId),
zap.String("sdkVersion", req.SdkVersion),
)...,
)
Expand Down
Binary file modified proto/gateway/proto_descriptor.pb
Binary file not shown.
63 changes: 38 additions & 25 deletions proto/gateway/service.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions proto/gateway/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ message GetEvaluationResponse {
message RegisterEventsRequest {
repeated bucketeer.event.client.Event events = 1;
string sdk_version = 2;
bucketeer.event.client.SourceId source_id = 3;
}

message RegisterEventsResponse {
Expand Down
5 changes: 5 additions & 0 deletions proto/proto.lock
Original file line number Diff line number Diff line change
Expand Up @@ -14986,6 +14986,11 @@
"id": 2,
"name": "sdk_version",
"type": "string"
},
{
"id": 3,
"name": "source_id",
"type": "bucketeer.event.client.SourceId"
}
]
},
Expand Down

0 comments on commit d09e2dd

Please sign in to comment.