chore: add source id to register events request #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
cre8ivejp
force-pushed
the
chore-add-source-i
branch
from
a254403
to
eb19acd
Compare
This was referenced Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #916
I added the source ID to the register events to improve the logging and metrics.
The other APIs already have this field in the request.
The source ID is in the events (Evaluation, Goal, and Metrics), but we must unmarshal the event when we want to use it. So, it would be much faster to have it in the requests like the other APIs. This will be helpful when we improve the API usage metrics.