Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add source id to register events request #915

Merged
merged 1 commit into from
Apr 15, 2024
Merged

chore: add source id to register events request #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/bucketeer/charts/api-gateway/values.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions pkg/gateway/api/api_grpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,6 +864,7 @@ func (s *grpcGatewayService) RegisterEvents(
log.FieldsFromImcomingContext(ctx).AddFields(
zap.Error(err),
zap.Any("events", req.Events),
zap.Any("sourceId", req.SourceId),
zap.String("sdkVersion", req.SdkVersion),
)...,
)
Expand All @@ -873,6 +874,7 @@ func (s *grpcGatewayService) RegisterEvents(
s.logger.Error("Failed to validate RegisterEvents request. Missing events.",
log.FieldsFromImcomingContext(ctx).AddFields(
zap.Error(err),
zap.Any("sourceId", req.SourceId),
zap.String("sdkVersion", req.SdkVersion),
)...,
)
Expand Down
Binary file modified proto/gateway/proto_descriptor.pb
View file
Open in desktop
Binary file not shown.
63 changes: 38 additions & 25 deletions proto/gateway/service.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions proto/gateway/service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ message GetEvaluationResponse {
message RegisterEventsRequest {
repeated bucketeer.event.client.Event events = 1;
string sdk_version = 2;
bucketeer.event.client.SourceId source_id = 3;
}

message RegisterEventsResponse {
Expand Down
5 changes: 5 additions & 0 deletions proto/proto.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14986,6 +14986,11 @@
"id": 2,
"name": "sdk_version",
"type": "string"
},
{
"id": 3,
"name": "source_id",
"type": "bucketeer.event.client.SourceId"
}
]
},
Expand Down
Loading