-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix protoc-gen-twirp-es.ts in the protoplugin-example package #367
Conversation
@@ -76,10 +76,10 @@ function generateTs(schema: Schema) { | |||
f.print(" ", method.output, ".fromJson(data as ", JsonValue, ")"); | |||
f.print(" );"); | |||
} | |||
f.print(" }"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this should be moved up even further inside the if (method.methodKind === MethodKind.Unary) {
condition. Otherwise if you have only streaming services, it will print an extra curly brace. Can you move up inside that if statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review.
It was indeed as you said.
I have corrected it, please check again.
Looks great. Thanks for the fix @s-hakase! |
This release includes the following: ## Enhancements * Support size-delimited messages by @timostamm in #387. ## Bug Fixes * Upgrade to Protobuf v22.0 by @smaye81 in #394. * Fix type declaration emitting when using NodeNext module resolution by @fubhy in #398. * Strip rewrite_imports parameter by @smaye81 in #386. ## New Contributors * @s-hakase made their first contribution in #367. * @balzdur made their first contribution in #368.
Fix the following bugs in the sample plugin