Fix protoc-gen-twirp-es.ts in the protoplugin-example package #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
smaye81
requested changes
Jan 19, 2023
| @@ -76,10 +76,10 @@ function generateTs(schema: Schema) { | |||
| f.print(" ", method.output, ".fromJson(data as ", JsonValue, ")"); | |||
| f.print(" );"); | |||
| } | |||
| f.print(" }"); | |||
There was a problem hiding this comment.
Actually this should be moved up even further inside the if (method.methodKind === MethodKind.Unary) { condition. Otherwise if you have only streaming services, it will print an extra curly brace. Can you move up inside that if statement?
There was a problem hiding this comment.
Thanks for the review.
It was indeed as you said.
I have corrected it, please check again.
smaye81
approved these changes
Jan 20, 2023
|
Looks great. Thanks for the fix @s-hakase! |
This was referenced Feb 28, 2023
Closed
Closed
Merged
smaye81
added a commit
that referenced
this pull request
Mar 2, 2023
This release includes the following: ## Enhancements * Support size-delimited messages by @timostamm in #387. ## Bug Fixes * Upgrade to Protobuf v22.0 by @smaye81 in #394. * Fix type declaration emitting when using NodeNext module resolution by @fubhy in #398. * Strip rewrite_imports parameter by @smaye81 in #386. ## New Contributors * @s-hakase made their first contribution in #367. * @balzdur made their first contribution in #368.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following bugs in the sample plugin