Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation and test for protoBase64 #368

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

balzdur
Copy link
Contributor

@balzdur balzdur commented Jan 19, 2023

Add some documentation and tests according to #366 (comment)

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you Thomas!

@timostamm timostamm merged commit 0b55fad into bufbuild:main Jan 19, 2023
@timostamm timostamm mentioned this pull request Jan 19, 2023
This was referenced Feb 28, 2023
smaye81 added a commit that referenced this pull request Mar 2, 2023
This release includes the following:

## Enhancements
* Support size-delimited messages by @timostamm in #387.

## Bug Fixes
*  Upgrade to Protobuf v22.0 by @smaye81 in #394.
* Fix type declaration emitting when using NodeNext module resolution by
@fubhy in #398.
*  Strip rewrite_imports parameter by @smaye81 in #386.

## New Contributors
* @s-hakase made their first contribution in #367.
* @balzdur made their first contribution in #368.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants