Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Expo v51 test fixture build #186

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Fix Expo v51 test fixture build #186

merged 3 commits into from
Jul 23, 2024

Conversation

twometresteve
Copy link
Contributor

Goal

Fix the Expo v51 test fixture build.

Supporting changes to our build infrastructure were also needed to make this work.

Changeset

  • Bundle Id updated to avoid a clash with our old Apple account.
  • Environment set to stop Expo clearing away working files - making it easier to debug future issues.
  • Environment variable name harmonised with infrastructure changes.

Testing

Covered by CI.

This was referenced Jul 23, 2024
Merged
Merged
@twometresteve twometresteve merged commit 31556f7 into v51/next Jul 23, 2024
6 checks passed
@twometresteve twometresteve deleted the tms/no-cleanup branch July 23, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yousif-bugsnag yousif-bugsnag yousif-bugsnag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twometresteve @yousif-bugsnag