Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Expo v51 test fixture build #186

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Fix Expo v51 test fixture build #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81d9970
Skip cleanup
twometresteve Jul 23, 2024
9e1123a
Use a fresh bundle id
twometresteve Jul 23, 2024
bf5153d
Use new style variable
twometresteve Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/fixtures/test-app/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
],
"ios": {
"supportsTablet": true,
"bundleIdentifier": "com.bugsnag.expo.testfixture",
"bundleIdentifier": "com.bugsnag.expo.fixture",
"buildNumber": "1",
"infoPlist": {
"NSAppTransportSecurity": {
Expand Down
2 changes: 1 addition & 1 deletion features/scripts/build-common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ sed -i '' "s/EXPO_EAS_PROJECT_ID/$EXPO_EAS_PROJECT_ID/g" app.json

./run-bugsnag-expo-cli-install

cp $EXPO_UNIVERSAL_CREDENTIALS_DIR/* .
cp $EXPO_CREDENTIALS_DIR/* .

echo "Common setup complete"

1 change: 1 addition & 0 deletions features/scripts/build-ios.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ set -e
if [[ -z ${EAS_LOCAL_BUILD_WORKINGDIR:-} ]]; then
EAS_LOCAL_BUILD_WORKINGDIR=$BUILDKITE_BUILD_CHECKOUT_PATH/features/fixtures/build
export EAS_LOCAL_BUILD_WORKINGDIR
export EAS_LOCAL_BUILD_SKIP_CLEANUP=1
fi

pushd features/fixtures/test-app
Expand Down
Loading