Trim nested arrays and drop metadata to save on payload size #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a payload contains an array of max length strings (4kb), trimming to 40 lines leaves 5kb for the rest of the payload including a long message and API key, et cetera. The only concern is losing debugging information to a smarter heuristic than truncating the lines outside the allowed length.
| else | ||
| value | ||
| end | ||
| end | ||
|
|
||
| def self.remove_metadata_from_value(object) | ||
| case object |
There was a problem hiding this comment.
This would be clearer and faster if it were more explicit.
payload.events.map do |event|
event[:metaData] = {}
endIn the (extreme) case that trimming strings and array truncation does not result in a payload of appropriate size, remove the `metaData` key from an array of events. The error will at least be reported, even if custom metadata is unavailable to assist with debugging.
kattrali
force-pushed
the
kattrali/trim-nested-arrays
branch
from
969be8e
to
f338ff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a payload is too large, the request is rejected by the Bugsnag API. This changeset adds a few more last resort adjustments to error reports to ensure at least something is sent.
If a payload is too large to be sent, the following steps are taken, and then only if the previous step did not put the payload size under the threshold: