Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim nested arrays and drop metadata to save on payload size #295

Merged
merged 3 commits into from
May 11, 2016

Commits on May 10, 2016

  1. Configuration menu
    Copy the full SHA
    fbe45ac View commit details
    Browse the repository at this point in the history
  2. [helpers] Truncate oversized arrays to 40 lines

    If a payload contains an array of max length strings (4kb), trimming to
    40 lines leaves 5kb for the rest of the payload including a long message
    and API key, et cetera. The only concern is losing debugging information
    to a smarter heuristic than truncating the lines outside the allowed
    length.
    kattrali committed May 10, 2016
    Configuration menu
    Copy the full SHA
    3f96d46 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2016

  1. [helpers] Drop metadata if payload too large

    In the (extreme) case that trimming strings and array truncation does
    not result in a payload of appropriate size, remove the `metaData` key
    from an array of events. The error will at least be reported, even if 
    custom metadata is unavailable to assist with debugging.
    kattrali committed May 11, 2016
    Configuration menu
    Copy the full SHA
    f338ff1 View commit details
    Browse the repository at this point in the history