Log delivery failures as errors #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help to differentiate errors that prevent things from being delivered from errors that we can continue from, e.g. errors raised in middleware
imjoehaines
force-pushed
the
log-delivery-failures-as-errors
branch
from
8e5e455
to
693a666
Compare
kattrali
approved these changes
Aug 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Currently we log exceptions in delivery as warnings, which is the same level that we log recoverable exceptions (e.g. exceptions in
on_errorcallbacks). This makes it easy to miss log messages that mean delivery has totally failed as they are mixed in with other messages of the same levelThis PR switches delivery failures to log at the error level so that they are more noticeable and to allow recoverable log messages to be suppressed without also suppressing unrecoverable errors
Testing
I've refactored the current logging tests to use a real
Loggerobject, which is the first commit. Use this comparison for only the delivery log level changes