Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log delivery failures as errors #681

Merged
merged 4 commits into from
Aug 18, 2021
Merged

Log delivery failures as errors #681

merged 4 commits into from
Aug 18, 2021

Commits on Aug 18, 2021

  1. Refactor logging tests to use a real Logger

    @imjoehaines
    imjoehaines committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    9bf9dd8 View commit details
    Browse the repository at this point in the history

  2. Add Configuration#error to log error messages

    @imjoehaines
    imjoehaines committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    7b4b57c View commit details
    Browse the repository at this point in the history

  3. Log delivery failures at error level 

    This should help to differentiate errors that prevent things
from being delivered from errors that we can continue from,
e.g. errors raised in middleware
    @imjoehaines
    imjoehaines committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    52f67e7 View commit details
    Browse the repository at this point in the history

  4. Update changelog

    @imjoehaines
    imjoehaines committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    693a666 View commit details
    Browse the repository at this point in the history