upgrading some lifecycle api versions #1254
Conversation
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
joe-kimmel-vmw
changed the title
| @@ -903,34 +762,11 @@ func testBuildPod(t *testing.T, when spec.G, it spec.S) { | |||
| } | |||
| assert.Equal(t, append(append([]string{ | |||
| "-layers=/layers", | |||
| "-analyzed=/layers/analyzed.toml", | |||
| "-run-image=builderregistry.io/run"}, | |||
There was a problem hiding this comment.
I think this is correct that the run-image wouldn't be there anymore, because we've upgraded the platform API version, and think that really is the main change, but uh... cc @natalieparellano :)
There was a problem hiding this comment.
We should still provide -run-image to the analyzer. It is only removed as a flag to the exporter on newer platforms.
…form apis Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
| func() []string { | ||
| if !platformAPILessThan07 { | ||
| return []string{"-run-image=" + runImage} | ||
| } | ||
| return []string{} | ||
| }(), |
There was a problem hiding this comment.
This func, along with L276-L278 can be removed. The args func just appends a bunch of string slices together, so if we return an empty slice, it's a noop either way.
| }, | ||
| []corev1.VolumeMount{}), |
There was a problem hiding this comment.
The volumeMounts func does the same thing as args, so passing in an empty slice is noop
| }, | |
| []corev1.VolumeMount{}), | |
| }), |
| return []string{} | ||
| }(), | ||
| []string{fmt.Sprintf("-report=%s", ReportTOMLPath)}, | ||
| []string{}, |
There was a problem hiding this comment.
Empty slice is noop
| []string{}, |
| } else { | ||
| return []string{fmt.Sprintf("-process-type=web")} | ||
| } | ||
| return []string{fmt.Sprintf("-process-type=web")} |
There was a problem hiding this comment.
| return []string{fmt.Sprintf("-process-type=web")} | |
| return nil |
There was a problem hiding this comment.
Now, platformAPI.GreaterThan(semver.MustParse("0.5")) will always be true
|
superseded by #1305 |
No description provided.