Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading some lifecycle api versions #1254

Closed
wants to merge 3 commits into from
Closed

upgrading some lifecycle api versions #1254

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
102d497
maybe upgrading some lifecycle api versions
joe-kimmel-vmw Jul 11, 2023
37a9406
finish cnb platform api upgrades and clean up unit tests
joe-kimmel-vmw Jul 12, 2023
c06eb09
simplify the build_pod even more now that we're ditching old cnb plat…
joe-kimmel-vmw Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/rebase/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func rebase(tags []string, logger *log.Logger) error {

rebaser := lifecycle.Rebaser{
Logger: cmd.DefaultLogger,
PlatformAPI: api.MustParse("0.9"),
PlatformAPI: api.MustParse("0.11"),
}
report, err := rebaser.Rebase(appImage, newBaseImage, appImage.Name(), tags[1:])
if err != nil {
Expand Down
6 changes: 3 additions & 3 deletions pkg/apis/build/v1alpha2/build_pod.go
View file
Open in desktop
chenbh marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -1154,10 +1154,10 @@ func (b *Build) setupCosignVolumes(secrets []corev1.Secret) ([]corev1.Volume, []
}

var (
lowestSupportedPlatformVersion = semver.MustParse("0.3")
lowestSupportedPlatformVersion = semver.MustParse("0.7")
chenbh marked this conversation as resolved.
Show resolved Hide resolved

supportedPlatformAPIVersionsWithWindowsAndReportToml = []*semver.Version{semver.MustParse("0.9"), semver.MustParse("0.8"), semver.MustParse("0.7"), semver.MustParse("0.6"), semver.MustParse("0.5"), semver.MustParse("0.4")}
joe-kimmel-vmw marked this conversation as resolved.
Show resolved Hide resolved
supportedPlatformAPIVersions = append(supportedPlatformAPIVersionsWithWindowsAndReportToml, semver.MustParse("0.3"))
supportedPlatformAPIVersionsWithWindowsAndReportToml = []*semver.Version{semver.MustParse("0.11"), semver.MustParse("0.10"), semver.MustParse("0.9"), semver.MustParse("0.8"), semver.MustParse("0.7")}
supportedPlatformAPIVersions = supportedPlatformAPIVersionsWithWindowsAndReportToml
)

func (bc BuildContext) highestSupportedPlatformAPI(b *Build) (*semver.Version, error) {
Expand Down