Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename extension-author-guide to extension-guide #587

Merged
merged 4 commits into from
Jun 10, 2023

Conversation

joe-kimmel-vmw
Copy link
Contributor

with redirects

Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

@AidanDelaney
Copy link
Member

Can you git rebase -i --signoff main? And then force push the branch.

with redirects

Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
@joe-kimmel-vmw
Copy link
Contributor Author

Can you git rebase -i --signoff main? And then force push the branch.

✅ thanks @AidanDelaney

@joe-kimmel-vmw joe-kimmel-vmw marked this pull request as ready for review May 6, 2023 23:29
@joe-kimmel-vmw joe-kimmel-vmw requested a review from a team as a code owner May 6, 2023 23:29
@natalieparellano
Copy link
Member

@joe-kimmel-vmw would it be possible to fold this PR into #581? That also expands on the extension guide and creates new links... apologies I didn't notice that earlier. Maybe we could pair on it?

@AidanDelaney AidanDelaney merged commit 8fade97 into buildpacks:main Jun 10, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 10, 2023
rename extension-author-guide to extension-guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants