Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo run image extension #581

Merged
merged 24 commits into from
Aug 14, 2023
Merged

Demo run image extension #581

merged 24 commits into from
Aug 14, 2023

Conversation

natalieparellano
Copy link
Member

No description provided.

…after every failed build

The hello-extensions buildpack can be configured through the environment after buildpacks/samples#142 lands

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
If we're extending the run image it must be in a registry

Signed-off-by: Natalie Arellano <narellano@vmware.com>
When both pack & lifecycle are released and the samples are updated, we can revert this commit

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Copy link
Member Author

Note: the tests for this PR are going to continue to fail until pack 0.30.0 exists 😿

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
We pushed it in an earlier step

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Copy link
Member Author

@AidanDelaney do you approve this one?

Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AidanDelaney AidanDelaney merged commit 77adc63 into main Aug 14, 2023
3 checks passed
@AidanDelaney AidanDelaney deleted the runext/demo branch August 14, 2023 14:49
github-actions bot pushed a commit that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants