-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extensions demo now that samples repo has been updated #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to re-create the builder, we just need to update the env vars passed to the buildpack to make it require things from extensions. Signed-off-by: Natalie Arellano <narellano@vmware.com>
This also appears to be blocked on upgrading the lifecycle to at least 0.17.0-xxx due to the inclusion of |
Use pre-release pack to build images that use extensions Signed-off-by: Aidan Delaney <aidan.delaney@gmail.com>
We have replaced the `tree` extension example with `vim` Signed-off-by: Aidan Delaney <aidan.delaney@gmail.com>
Signed-off-by: Aidan Delaney <aidan.delaney@gmail.com>
Signed-off-by: Aidan Delaney <aidan.delaney@gmail.com>
39e85f5
to
5654ef3
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
cf931a5
to
e275bf8
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
e275bf8
to
85fc5dd
Compare
AidanDelaney
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
Fix extensions demo now that samples repo has been updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to re-create the builder, we just need to update the env vars passed to the buildpack to make it require things from extensions.
I wanted to make this fix as part of #581, but that PR is blocked on there being new versions of pack and the lifecycle.