Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rebasable label small description and updated inspect-image outputs #592

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

dlion
Copy link
Member

@dlion dlion commented Jun 21, 2023

Update the documentation about the Rebasable feature implementation
PR: buildpacks/pack#1806
Issue: buildpacks/pack#1799

Changes:

  • Added a small description of the Rebasable label
  • Updated the inspect-image outputs

…n of it

Signed-off-by: Domenico Luciani <dluciani@vmware.com>
…label appear only when a rebasable field has been populate and is true

Signed-off-by: Domenico Luciani <dluciani@vmware.com>
@dlion dlion changed the title Add Rebasable label into the inspect-image outputs Add Rebasable label small description Jun 21, 2023
…changes on the PR #1799

Signed-off-by: Domenico Luciani <dluciani@vmware.com>
@dlion dlion changed the title Add Rebasable label small description Add Rebasable label small description and updated inspect-image outputs Jun 21, 2023
@AidanDelaney
Copy link
Member

Thanks @dlion, the test fail because your feature has not yet landed. The tests will pass once your PR is merged into pack and a release is made.

Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AidanDelaney AidanDelaney merged commit 50c1d29 into buildpacks:main Aug 11, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
Add Rebasable label small description and updated inspect-image outputs
@dlion dlion deleted the 1799-pack-inspect branch August 18, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants