Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack inspect <app-image> shows if the image is rebasable or not #1806

Merged
merged 12 commits into from
Aug 4, 2023

Conversation

dlion
Copy link
Member

@dlion dlion commented Jun 19, 2023

Summary

Now pack inspect <image> shows a Rebasable label on the inspect output based on the reabasability of the image if the label has been set or if it is true

Rebasable: true if it's rebasable, Rebasable: false if it's not.

It works either for local or remote images

Output

Before Remote output

REMOTE:

Stack: test.stack.id.remote

Base Image:
  Reference: some-remote-run-image-reference
  Top Layer: some-remote-top-layer

Run Images:
  user-configured-mirror-for-remote        (user-configured)
  some-remote-run-image
  some-remote-mirror
  other-remote-mirror

Buildpacks:
  ID                          VERSION        HOMEPAGE
  test.bp.one.remote          1.0.0          https://some-homepage-one
  test.bp.two.remote          2.0.0          https://some-homepage-two
  test.bp.three.remote        3.0.0          -

Processes:
  TYPE                              SHELL        COMMAND                      ARGS                     WORK DIR
  some-remote-type (default)        bash         /some/remote command         some remote args         /some-test-work-dir
  other-remote-type                              /other/remote/command        other remote args        /other-test-work-dir

After remote output with rebasable label set to true


Stack: test.stack.id.remote

Base Image:
  Reference: some-remote-run-image-reference
  Top Layer: some-remote-top-layer

Run Images:
  user-configured-mirror-for-remote        (user-configured)
  some-remote-run-image
  some-remote-mirror
  other-remote-mirror

Rebasable: true

Buildpacks:
  ID                          VERSION        HOMEPAGE
  test.bp.one.remote          1.0.0          https://some-homepage-one
  test.bp.two.remote          2.0.0          https://some-homepage-two
  test.bp.three.remote        3.0.0          -

Processes:
  TYPE                              SHELL        COMMAND                      ARGS                     WORK DIR
  some-remote-type (default)        bash         /some/remote command         some remote args         /some-test-work-dir
  other-remote-type                              /other/remote/command        other remote args        /other-test-work-dir

Documentation - WIP

Related

Resolves #1799

@dlion dlion requested review from a team as code owners June 19, 2023 09:45
@github-actions github-actions bot added this to the 0.30.0 milestone Jun 19, 2023
@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Jun 19, 2023
@dlion dlion marked this pull request as draft June 19, 2023 12:57
@jjbustamante jjbustamante modified the milestones: 0.30.0, 0.31.0 Jun 20, 2023
@dlion dlion marked this pull request as ready for review June 21, 2023 09:41
@github-actions github-actions bot modified the milestones: 0.31.0, 0.30.0 Jun 21, 2023
@natalieparellano natalieparellano modified the milestones: 0.30.0, 0.30.1 Jun 22, 2023
@natalieparellano
Copy link
Member

@dlion is it possible you could fix the merge conflicts on this one?

@natalieparellano natalieparellano modified the milestones: 0.30.1, 0.30.0 Aug 4, 2023
@dlion dlion force-pushed the 1799-pack-inspect branch 3 times, most recently from d4f62c1 to 80f2831 Compare August 4, 2023 15:10
Domenico Luciani added 9 commits August 4, 2023 17:22
…al rebasable images

Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
…ages

Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
…f concerns

Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Domenico Luciani added 2 commits August 4, 2023 17:22
…lity which until now was always set as a true

Signed-off-by: Domenico Luciani <dluciani@vmware.com>
… assumption that the rebasable is true when true or not set, false otherwise

Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the PR @dlion!

@jkutner jkutner merged commit 2462349 into buildpacks:main Aug 4, 2023
18 checks passed
@dlion dlion deleted the 1799-pack-inspect branch August 5, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pack inspect <app-image> should show if the image is rebasable or not
4 participants