-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pack inspect <app-image> shows if the image is rebasable or not #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type/chore
Issue that requests non-user facing changes.
type/enhancement
Issue that requests a new feature or improvement.
labels
Jun 19, 2023
@dlion is it possible you could fix the merge conflicts on this one? |
dlion
force-pushed
the
1799-pack-inspect
branch
3 times, most recently
from
August 4, 2023 15:10
d4f62c1
to
80f2831
Compare
…al rebasable images Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
…ages Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
…f concerns Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
…lity which until now was always set as a true Signed-off-by: Domenico Luciani <dluciani@vmware.com>
… assumption that the rebasable is true when true or not set, false otherwise Signed-off-by: Domenico Luciani <dluciani@vmware.com>
dlion
force-pushed
the
1799-pack-inspect
branch
from
August 4, 2023 15:22
80f2831
to
fe499fb
Compare
natalieparellano
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the PR @dlion!
jkutner
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type/chore
Issue that requests non-user facing changes.
type/enhancement
Issue that requests a new feature or improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now
pack inspect <image>
shows aRebasable
label on the inspect output based on the reabasability of the image if the label has been set or if it istrue
Rebasable: true
if it's rebasable,Rebasable: false
if it's not.It works either for local or remote images
Output
Before Remote output
After remote output with
rebasable
label set to trueDocumentation - WIP
Related
Resolves #1799