Imgutil adding tests, test utils and refactor #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlion
force-pushed
the
524-insecure-registries
branch
4 times, most recently
from
99aeb30
to
872f83d
Compare
7 tasks
dlion
commented
Jul 25, 2023
|
@dlion is it possible to resolve the merge conflict? |
added 2 commits
July 26, 2023 10:56
…lliding names Signed-off-by: Domenico Luciani <dluciani@vmware.com>
pulls the remote image from the insecure registry as well Signed-off-by: Domenico Luciani <dluciani@vmware.com>
dlion
force-pushed
the
524-insecure-registries
branch
from
872f83d
to
e9805cc
Compare
|
@natalieparellano done 😄 |
|
@natalieparellano is there anything else I need to do on this PR to get merged? |
natalieparellano
approved these changes
Aug 1, 2023
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://github.com/buildpacks/rfcs/blob/main/text/0111-support-insecure-registries.md