-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imgutil adding tests, test utils and refactor #211
Merged
natalieparellano
merged 4 commits into
buildpacks:main
from
dlion:524-insecure-registries
Aug 2, 2023
Merged
Imgutil adding tests, test utils and refactor #211
natalieparellano
merged 4 commits into
buildpacks:main
from
dlion:524-insecure-registries
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99aeb30
to
872f83d
Compare
7 tasks
dlion
commented
Jul 25, 2023
@dlion is it possible to resolve the merge conflict? |
…lliding names Signed-off-by: Domenico Luciani <dluciani@vmware.com>
pulls the remote image from the insecure registry as well Signed-off-by: Domenico Luciani <dluciani@vmware.com>
872f83d
to
e9805cc
Compare
@natalieparellano done 😄 |
@natalieparellano is there anything else I need to do on this PR to get merged? |
natalieparellano
approved these changes
Aug 1, 2023
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://github.com/buildpacks/rfcs/blob/main/text/0111-support-insecure-registries.md