Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Sub Team Maintainer (formerly author) Creates Repo Issues #106

Merged
merged 6 commits into from
Oct 1, 2020

Conversation

dfreilich
Copy link
Member

Readable

Signed-off-by: David Freilich dfreilich@vmware.com

Signed-off-by: David Freilich <dfreilich@vmware.com>
@dfreilich dfreilich requested a review from a team as a code owner August 7, 2020 14:04
@dfreilich dfreilich changed the title Add Create Repo Issues RFC Author Creates Repo Issues Aug 7, 2020
@dfreilich dfreilich changed the title Author Creates Repo Issues RFC: Author Creates Repo Issues Aug 7, 2020
@nebhale nebhale requested a review from a team August 11, 2020 23:00
@nebhale nebhale requested a review from a team August 12, 2020 15:11
@hone
Copy link
Member

hone commented Aug 12, 2020

I think this makes a lot of sense if the RFC comes from a contributor/core team member, but I've noticed in the prior art that none of the other RFC processes follow this practice. I wonder if it this instead should fall upon the subteam to manage/create issues when they're finalized maybe in the subteam/maintainers meeting once a week to go over finalized RFCs. This requires a lot more onus on the RFC author especially if they are a non-contributor.

@dfreilich
Copy link
Member Author

@hone I definitely hear that. A suggestion that came up in conversation (I believe from @natalieparellano) was to add a section like

# Suggested Issues

to the RFC template, where the author of the PR would write what repos/issues they would create, which could then get approval from the reviewers, as well as additional suggestions.

To lower the barrier of entry, I would add that while we welcome well-fleshed out issues, even placeholder ones that link to the RFC are a better start than no issues.

@nebhale nebhale requested a review from a team August 12, 2020 19:14
@nebhale nebhale requested a review from a team August 19, 2020 19:10
Signed-off-by: David Freilich <dfreilich@vmware.com>
@dfreilich dfreilich changed the title RFC: Author Creates Repo Issues RFC: Sub Team Maintainer (formerly author) Creates Repo Issues Sep 3, 2020
@nebhale nebhale requested a review from a team September 9, 2020 17:48
@nebhale nebhale requested a review from a team September 9, 2020 21:16
text/0000-create-repo-issues.md Outdated Show resolved Hide resolved

# How it Works
[how-it-works]: #how-it-works
When a PR has been accepted (after FCP has concluded), the sub-team maintainers make issues (tagging the RFC PR) in the relevant buildpack repos, and labels the PR `issues-created`. At that point, the RFC PR may be merged in.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that some sub-teams have multiple maintainers, there may still be some potential for ambiguity around who will handle a particular RFC. I propose that when we move RFCs into FCP we should assign a sub-team maintainer to the PR and they will be responsible for creating the issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekcasey my thought is that this would happen during the weekly subteam meetings, but I don't feel strongly about it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekcasey I don't know whether we need that level of process at this point. I agree with @hone that I had felt it could be done during the subteam meetings, as one of the repeating action items. Should I clarify that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some RFCs that require multiple sub-teams to create issues from a single RFC. For the sake of minimizing coordination could we maybe change this to be a label per subteam.

For example:

  • issues-created/platform
  • issues-created/implementation

If no issues need to be created for a given subteam they can add that label for brevity sake. We can further automate this process by checking that these labels are present.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I incorporated @jromero's feedback. LMK what you think.

@nebhale nebhale requested a review from a team September 10, 2020 18:53
Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
@dfreilich
Copy link
Member Author

@nebhale and @jkutner I made some changes since you last checked it over. Just want to make sure you're still ok with the contents.

Signed-off-by: David Freilich <dfreilich@vmware.com>
@nebhale nebhale requested a review from a team September 21, 2020 20:19
@hone
Copy link
Member

hone commented Sep 23, 2020

Once this RFC is merged in that means someone from the core team will need to create the issue on this repo. :)

@ekcasey
Copy link
Member

ekcasey commented Sep 23, 2020

Final Comment Period with merge disposition, closing on 30 September, 2020.

Signed-off-by: David Freilich <dfreilich@vmware.com>

Co-authored-by: Javier Romero <root@jromero.codes>
ekcasey added a commit that referenced this pull request Oct 1, 2020
[#106]

Signed-off-by: Emily Casey <ecasey@vmware.com>
@ekcasey ekcasey merged commit 49a4b85 into buildpacks:main Oct 1, 2020
@ekcasey ekcasey mentioned this pull request Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants