Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues and labels #117

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Issues and labels #117

merged 2 commits into from
Oct 8, 2020

Conversation

ekcasey
Copy link
Member

@ekcasey ekcasey commented Oct 5, 2020

Updates automation and README for #108 and #106

This automation supports RFC 0060 - https://github.com/buildpacks/rfcs/blob/main/text/0060-create-repo-issues.md

Signed-off-by: Emily Casey <ecasey@vmware.com>
Adds the following to the RFC process
* Issue creation
* Spec and audience albels

Documents merge-rfc.sh script

Signed-off-by: Emily Casey <ecasey@vmware.com>
@ekcasey ekcasey requested a review from a team as a code owner October 5, 2020 15:44
@nebhale nebhale requested a review from a team October 5, 2020 15:48
@ekcasey ekcasey requested a review from jromero October 5, 2020 15:53
Comment on lines +27 to +28
* `spec/<spec>` - For example, an RFC proposing a change to the Platform Specification will be labeled with `spec/platform`.
* `audience/<audience>`- For example, an RFC proposing a new pack feature for buildpack authors will be labeled with `audience/buildpack-author`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to specify what are valid values for <spec> and <audience>. I think <spec> could probably be a generic description, but I imagine <audience> should be defined somewhere and linked to?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another alternative is we can prepoulate the labels and we can easily extend without needing new PRs to the README.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to have to update the readme everytime we add a new extension spec or come up with a new persona mostly because I am pretty sure we will forget to do it. So I went ahead and prepopulated some labels https://github.com/buildpacks/rfcs/labels?sort=name-asc

- Create a corresponding issue in the appropriate repo.
- Fill in the remaining metadata at the top.
- Commit everything.
1. The following labels will be applied as appropriate:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly about this suggestion.

Suggested change
1. The following labels will be applied as appropriate:
1. The following labels will be applied as appropriate from the list of prepopulated labels:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind I am going to pass on this change. I think the choosing a label from the existing options will feel natural and I don't want to preclude creating a new label on the fly if it is appropriate (a new extension is proposed or a new audience is identified).

@ekcasey ekcasey merged commit 2824aea into main Oct 8, 2020
@ekcasey ekcasey deleted the issues-and-labels branch October 8, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants