-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Lifecycle Compatibility Verification #29
Conversation
I like how thorough this is in terms of alternatives and their pros/cons. I tend to agree that where you landed (adding a |
I do wonder if the checker could return more than just a pass/fail. For instance, an error code for saying that the provided version is "too new" and a different error code for "too old", in case platforms want to do further logic or have it inform their own error messages (analogous to string comparisons returning +1, 0, or -1 to signify which thing was greater). |
@sclevine updated with the use of env vars instead of flag arguments. We would still need another binary to have a guaranteed entrypoint. For example, in the case that |
From the CNB WG meeting today, do we need to take into account API checks for the |
If it turns out we should be checking API versions in
I know there were talks about removing a binary as a failure case. Perhaps we leave old binaries around for X amount of time in a checks-only/deprecation mode. |
@jabrown85 can you elaborate on your findings as to what aspects of the launcher the platform interacts with? CC: @hone RE:
|
I'd like to propose an additional alternative that wouldn't require adding any extra flags, commands, or binaries. What if all the lifecycle binaries checked the environment for values in |
Signed-off-by: Simon Jones <sijones@pivotal.io> Signed-off-by: Javier Romero <jromero@pivotal.io>
@sclevine I've made changes to the RFC based on your feedback.
|
Closing due to new PR #34 Long story short, I forked the repo incorrectly initially. I went ahead and fixed it but by doing so this PR became orphaned. |
[resolves buildpacks#52] Signed-off-by: Ben Hale <bhale@pivotal.io>
readable